Fix hardcoded ~/.ldk-server default path in CLI help and error messages#169
Merged
benthecarman merged 1 commit intolightningdevkit:mainfrom Mar 24, 2026
Merged
Conversation
The CLI help text and error messages always reported ~/.ldk-server as the default config location, but on macOS the actual default is ~/Library/Application Support/ldk-server. Introduce a DEFAULT_DIR const using cfg\!() to select the correct platform-specific path, and reference it in all help text and error messages. AI tools were used in preparing this commit.
|
I've assigned @benthecarman as a reviewer! |
tnull
approved these changes
Mar 24, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
I think we discussed this in the original PR and decided not to bother. No too strong opinion, so fine by me.
But, are we really expecting people to run this in production on macOS or even Windows? For any other use the user needs to override the paths anyways, no?
Contributor
Author
|
All I can say is that I was confused because of the wrong docs. It's no big deal ofc, but also -15/+15 so why not. |
benthecarman
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI help text and error messages always reported ~/.ldk-server as the default config location, but on macOS the actual default is ~/Library/Application Support/ldk-server. Introduce a DEFAULT_DIR const using cfg!() to select the correct platform-specific path, and reference it in all help text and error messages.
AI tools were used in preparing this commit.